netdev - Re: [PATCH 04/15] [NETFILTER]: Use proc_create() to setup ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080228.140530.00362906.davem@davemloft.net>
Date:	Thu, 28 Feb 2008 14:05:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 04/15] [NETFILTER]: Use proc_create() to setup
 ->proc_fops first

From: Wang Chen <wangchen@...fujitsu.com>
Date: Thu, 28 Feb 2008 18:56:08 +0800

> Use proc_create() and proc_net_fops_create() to
> make sure that ->proc_fops be setup before gluing
> PDE to main tree.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

I'll forward this to Patrick McHardy and netfilter-devel.
Please submit netfilter changes that way in the future.

> @@ -588,10 +588,10 @@ static int __init ip_queue_init(void)
>  	}
>  
>  #ifdef CONFIG_PROC_FS
> -	proc = create_proc_entry(IPQ_PROC_FS_NAME, 0, init_net.proc_net);
> +	proc = proc_net_fops_create(&init_net, IPQ_PROC_FS_NAME,
> +				    0, &ip_queue_proc_fops);
>  	if (proc) {
>  		proc->owner = THIS_MODULE;
> -		proc->proc_fops = &ip_queue_proc_fops;
>  	} else {
>  		printk(KERN_ERR "ip_queue: failed to create proc entry\n");
>  		goto cleanup_ipqnl;

Doesn't ->owner have the same visibility problems that
->proc_fops does?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html