netdev - Re: [PATCH 03/15] [SUNRPC]: Use proc_create() to setup ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Feb 2008 14:02:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 03/15] [SUNRPC]: Use proc_create() to setup ->proc_fops
 first

From: Wang Chen <wangchen@...fujitsu.com>
Date: Thu, 28 Feb 2008 18:55:40 +0800

> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Applied.

> @@ -229,9 +229,8 @@ do_register(const char *name, void *data, const struct file_operations *fops)
>  	rpc_proc_init();
>  	dprintk("RPC:       registering /proc/net/rpc/%s\n", name);
>  
> -	ent = create_proc_entry(name, 0, proc_net_rpc);
> +	ent = proc_create(name, 0, proc_net_rpc, fops);
>  	if (ent) {
> -		ent->proc_fops = fops;
>  		ent->data = data;
>  	}
>  	return ent;

For this case it appears that ent->data has the same kind of
visibility problem that ent->proc_fops does.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html