netdev - Re: [PATCH 03/15] [SUNRPC]: Use proc_create() to setup ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C79793.8060108@cn.fujitsu.com>
Date:	Fri, 29 Feb 2008 13:26:43 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, Alexey Dobriyan <adobriyan@...ru>
Subject: Re: [PATCH 03/15] [SUNRPC]: Use proc_create() to setup ->proc_fops
 first

David Miller said the following on 2008-2-29 6:02:
> From: Wang Chen <wangchen@...fujitsu.com>
> Date: Thu, 28 Feb 2008 18:55:40 +0800
> 
>> Use proc_create() to make sure that ->proc_fops be setup before gluing
>> PDE to main tree.
>>
>> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> 
> Applied.
> 
>> @@ -229,9 +229,8 @@ do_register(const char *name, void *data, const struct file_operations *fops)
>>  	rpc_proc_init();
>>  	dprintk("RPC:       registering /proc/net/rpc/%s\n", name);
>>  
>> -	ent = create_proc_entry(name, 0, proc_net_rpc);
>> +	ent = proc_create(name, 0, proc_net_rpc, fops);
>>  	if (ent) {
>> -		ent->proc_fops = fops;
>>  		ent->data = data;
>>  	}
>>  	return ent;
> 
> For this case it appears that ent->data has the same kind of
> visibility problem that ent->proc_fops does.
> 

Thanks Dave, I will check whether ->data also has the visibility problem.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html