netdev - Re: [PATCH 13/15] [8021Q]: Use proc_create() to setup ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080228.141519.48676600.davem@davemloft.net>
Date:	Thu, 28 Feb 2008 14:15:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 13/15] [8021Q]: Use proc_create() to setup ->proc_fops
 first

From: Wang Chen <wangchen@...fujitsu.com>
Date: Thu, 28 Feb 2008 18:58:24 +0800

> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Applied.

> @@ -182,13 +181,11 @@ int vlan_proc_add_dev(struct net_device *vlandev)
>  {
>  	struct vlan_dev_info *dev_info = vlan_dev_info(vlandev);
>  
> -	dev_info->dent = create_proc_entry(vlandev->name,
> -					   S_IFREG|S_IRUSR|S_IWUSR,
> -					   proc_vlan_dir);
> +	dev_info->dent = proc_create(vlandev->name, S_IFREG|S_IRUSR|S_IWUSR,
> +				     proc_vlan_dir, &vlandev_fops);
>  	if (!dev_info->dent)
>  		return -ENOBUFS;
>  
> -	dev_info->dent->proc_fops = &vlandev_fops;
>  	dev_info->dent->data = vlandev;
>  	return 0;
>  }

->data visibility issue
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html