netdev - Re: [PATCH 14/15] [WANROUTER]: Use proc_create() to setup ->proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080228.141611.43422202.davem@davemloft.net>
Date:	Thu, 28 Feb 2008 14:16:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 14/15] [WANROUTER]: Use proc_create() to setup
 ->proc_fops first

From: Wang Chen <wangchen@...fujitsu.com>
Date: Thu, 28 Feb 2008 18:58:35 +0800

> Use proc_create() to make sure that ->proc_fops be setup before gluing
> PDE to main tree.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Applied.

> @@ -329,10 +327,10 @@ int wanrouter_proc_add(struct wan_device* wandev)
>  	if (wandev->magic != ROUTER_MAGIC)
>  		return -EINVAL;
>  
> -	wandev->dent = create_proc_entry(wandev->name, S_IRUGO, proc_router);
> +	wandev->dent = proc_create(wandev->name, S_IRUGO,
> +				   proc_router, &wandev_fops);
>  	if (!wandev->dent)
>  		return -ENOMEM;
> -	wandev->dent->proc_fops	= &wandev_fops;
>  	wandev->dent->data	= wandev;
>  	return 0;
>  }

->data visibility issue
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html