netdev - Re: [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080303.115509.71743609.davem@davemloft.net>
Date:	Mon, 03 Mar 2008 11:55:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	den@...nvz.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/4 net-2.6.26] [IPV4]: Cleanup ip_options_compile.

From: "Denis V. Lunev" <den@...nvz.org>
Date: Mon,  3 Mar 2008 18:48:41 +0300

> Right now ip_options_compile is called twice as (NULL, skb) and (opt, NULL).
> So, let's move opt initialization into caller and remove this initialization
> branch.
> 
> Additionally, the field ip_options->is_data becomes not needed. All decisions
> should be made by the real skb availability.
> 
> Signed-off-by: Denis V. Lunev <den@...nvz.org>

I don't think this "is_data" elimination works.

Sometimes these option blobs come from the user or elsewhere.  And
that's why we have to sometimes use opt->__data instead of the SKB
embedded blob.

You also missed the is_data case in cipso_ipv4.c, so this wouldn't
even compile.  Is there something wrong with "git grep" on your
computer?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html