netdev - Re: [PATCH 3/4 net-2.6.26] [SCTP]: seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2008 11:56:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	den@...nvz.org
Cc:	netdev@...r.kernel.org, YOSHIFUJI@...ru
Subject: Re: [PATCH 3/4 net-2.6.26] [SCTP]: seq_printf format warning.
 (fixed)

From: "Denis V. Lunev" <den@...nvz.org>
Date: Mon,  3 Mar 2008 20:53:38 +0300

> sctp_association->hbinterval is unsigned long. Replace %8d with %8ld.
> 
> Signed-off-by: Denis V. Lunev <den@...nvz.org>
 ...
> diff --git a/net/sctp/proc.c b/net/sctp/proc.c
> index 82bea30..138ab5f 100644
> --- a/net/sctp/proc.c
> +++ b/net/sctp/proc.c
> @@ -325,7 +325,7 @@ static int sctp_assocs_seq_show(struct seq_file *seq, void *v)
>  		seq_printf(seq,
>  			   "%8p %8p %-3d %-3d %-2d %-4d "
>  			   "%4d %8d %8d %7d %5lu %-5d %5d "
> -			   "%8d %5d %5d %4d %4d %4d %8d ",
> +			   "%8lu %5d %5d %4d %4d %4d %8d ",
>  			   assoc, sk, sctp_sk(sk)->type, sk->sk_state,
>  			   assoc->state, hash,
>  			   assoc->assoc_id,

Haste makes waste.

You fixed up the patch but didn't update the changelog entry.  I've
fixed it up, but please just take your time when respinning patches to
avoid errors like this.  It is not a race, and you will not be timed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html