netdev - Re: [PATCH 1/2][PPPOL2TP]: Make locking calls softirq-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080305.183921.47316347.davem@davemloft.net>
Date:	Wed, 05 Mar 2008 18:39:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org, jarkao2@...il.com
Subject: Re: [PATCH 1/2][PPPOL2TP]: Make locking calls softirq-safe

From: James Chapman <jchapman@...alix.com>
Date: Wed, 5 Mar 2008 23:20:37 GMT

> Fix locking issues in the pppol2tp driver which can cause a kernel
> crash on SMP boxes. There were two problems:-
> 
> 1. The driver was violating read_lock() and write_lock() scheduling
>    rules because it wasn't using softirq-safe locks in softirq
>    contexts. So we now consistently use the _bh variants of the lock
>    functions.
> 
> 2. The driver was calling sk_dst_get() in pppol2tp_xmit() which was
>    taking sk_dst_lock in softirq context. We now call __sk_dst_get().
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html