netdev - Re: [PATCH 2/2][PPPOL2TP]: Fix SMP issues in skb reorder queue handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080305.184014.240862635.davem@davemloft.net>
Date:	Wed, 05 Mar 2008 18:40:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org, jarkao2@...il.com
Subject: Re: [PATCH 2/2][PPPOL2TP]: Fix SMP issues in skb reorder queue
 handling

From: James Chapman <jchapman@...alix.com>
Date: Wed, 5 Mar 2008 23:20:39 GMT

> When walking a session's packet reorder queue, use
> skb_queue_walk_safe() since the list could be modified inside the
> loop.
> 
> Rearrange the unlinking skbs from the reorder queue such that it
> is done while the queue lock is held in pppol2tp_recv_dequeue() when
> walking the skb list.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>

Also applied, th anks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html