netdev - drivers/net/tokenring/smctr.c: logical-bitwise or confusion?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <47D45A0F.1060102@tiscali.nl>
Date:	Sun, 09 Mar 2008 22:43:43 +0100
From:	Roel Kluin <12o3l@...cali.nl>
To:	jschlst@...ba.org, p_gortmaker@...oo.com
CC:	netdev@...r.kernel.org
Subject: drivers/net/tokenring/smctr.c: logical-bitwise or confusion?

drivers/net/tokenring/smctr.c:3416

tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) || IBM_PASS_SOURCE_ADDR);

shouldn't this be a bit-wise or?
from drivers/net/tokenring/smctr.h:50:

#define      IBM_PASS_SOURCE_ADDR    0x01
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html