netdev - Re: drivers/net/tokenring/smctr.c: logical-bitwise or confusion?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 9 Mar 2008 20:09:39 -0400 (EDT)
From:	Paul Gortmaker <p_gortmaker@...oo.com>
To:	Roel Kluin <12o3l@...cali.nl>, jschlst@...ba.org
Cc:	netdev@...r.kernel.org
Subject: Re: drivers/net/tokenring/smctr.c: logical-bitwise or confusion?

--- Roel Kluin <12o3l@...cali.nl> wrote:

> drivers/net/tokenring/smctr.c:3416
> 
> tsv->svv[0] = ((tx_fstatus & 0x0100 >> 6) || IBM_PASS_SOURCE_ADDR);
> 
> shouldn't this be a bit-wise or?
> from drivers/net/tokenring/smctr.h:50:
> 
> #define      IBM_PASS_SOURCE_ADDR    0x01

Probably a safe bet that is what they meant to have. Since
as it stands, gcc will (correctly) optimize that into:

tsv->svv[0]= 1;

which probably isn't particularly useful.

Paul.

      Connect with friends from any web browser - no download required. Try the new Yahoo! Canada Messenger for the Web BETA at http://ca.messenger.yahoo.com/webmessengerpromo.php
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html