netdev - Re: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 19 Mar 2008 21:26:13 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
Cc:	Johannes Berg <johannes@...solutions.net>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Jeff Garzik <jeff@...zik.org>, Felix Fietkau <nbd@...nwrt.org>
Subject: Re: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC

Florian Fainelli <florian.fainelli@...ecomint.eu> :
[...]
> +	ret = request_irq(lp->und_irq, &korina_und_interrupt,
> +			IRQF_SHARED | IRQF_DISABLED, "Ethernet Underflow", dev);
> +	if (ret < 0) {
> +		printk(KERN_ERR DRV_NAME "%s: unable to get UND IRQ %d\n",
> +		    dev->name, lp->und_irq);
> +		goto err_free_ovr_irq;
> +	}
> +
> +err_free_ovr_irq:
> +	free_irq(lp->ovr_irq, dev);
> +err_free_tx_irq:
> +	free_irq(lp->tx_irq, dev);
> +err_free_rx_irq:
> +	free_irq(lp->rx_irq, dev);
> +err_release:
> +	korina_free_ring(dev);
> +	goto out;
> +out:
> +	return ret;

*ouch*

Please have some sleep, some coffee (in that order) and write down the
sequence of instructions of the code above when request_irq does _not_
fail.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html