[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080321171731.2447b435@extreme>
Date: Fri, 21 Mar 2008 17:17:31 -0700
From: Stephen Hemminger <shemminger@...tta.com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] socket: SOCK_DEBUG type checking
On Fri, 21 Mar 2008 15:56:00 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Fri, 21 Mar 2008 07:51:32 -0700
>
> > Use the inline trick (same as pr_debug) to get checking
> > of debug statements even if no code is generated.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>
> Applied, and I'll push to net-2.6.26 after some build
> testing.
>
> Although the use of SOCK_DEBUG is so esoteric and sparse,
> I can't see how any of it can be useful for any kind of
> debugging.
>
> I'd say we should just remove this thing.
Agreed, that was the other alternative, just saw it while
looking at filter stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists