netdev - Re: [VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080326.001557.147425396.davem@davemloft.net>
Date:	Wed, 26 Mar 2008 00:15:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	netdev@...r.kernel.org
Subject: Re: [VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying
 device

From: Patrick McHardy <kaber@...sh.net>
Date: Wed, 26 Mar 2008 06:44:40 +0100

> commit 23309e2679f45ffd6406a269310742a05eabfd99
> Author: Patrick McHardy <kaber@...sh.net>
> Date:   Wed Mar 26 06:29:07 2008 +0100
> 
>     [VLAN]: Don't copy ALLMULTI/PROMISC flags from underlying device
> 
>     Changing these flags requires to use dev_set_allmulti/dev_set_promiscuity
>     or dev_change_flags. Setting it directly causes two unwanted effects:
> 
>     - the next dev_change_flags call will notice a difference between
>       dev->gflags and the actual flags, enable promisc/allmulti
>       mode and incorrectly update dev->gflags
> 
>     - this keeps the underlying device in promisc/allmulti mode until
>       the VLAN device is deleted
> 
>     Signed-off-by: Patrick McHardy <kaber@...sh.net>

Applied and I'll queue this up for -stable too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html