netdev - Re: [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080326.001647.97478240.davem@davemloft.net>
Date:	Wed, 26 Mar 2008 00:16:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	jeff@...zik.org, jdike@...toit.com,
	user-mode-linux-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [UML]: uml-net: don't set IFF_ALLMULTI in set_multicast_list

From: Patrick McHardy <kaber@...sh.net>
Date: Wed, 26 Mar 2008 07:13:51 +0100

> Jeff Garzik wrote:
> >>  static void uml_net_set_multicast_list(struct net_device *dev)
> >>  {
> >> -    if (dev->flags & IFF_PROMISC)
> >> -        return;
> >> -    else if (dev->mc_count)
> >> -        dev->flags |= IFF_ALLMULTI;
> >> -    else dev->flags &= ~IFF_ALLMULTI;
> >> +    return;
> >>  }
> > 
> > 
> > 
> > Might as well just delete the hook at that point...
> 
> 
> I kept it so SIOCADDMULTI/SIOCDELMULTI ioctls continue to
> work on UML devices. I don't know if any userspace applications
> check for errors when using these ioctls, this way nothing
> can break.

Good idea, patch applied to net-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html