netdev - Re: [PATCH] Net: Don't send ICMP_FRAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080328.162412.50278632.davem@davemloft.net>
Date:	Fri, 28 Mar 2008 16:24:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	rusty@...tcorp.com.au, netdev@...r.kernel.org, jheffner@....edu
Subject: Re: [PATCH] Net: Don't send ICMP_FRAG_NEEDED for GSO packets

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 28 Mar 2008 16:40:43 +0800

> On Fri, Mar 28, 2008 at 07:34:08PM +1100, Rusty Russell wrote:
> > Commit 9af3912ec9e30509b76cb376abb65a4d8af27df3 added a new check to
> > send ICMP fragmentation needed for large packets.
> > 
> > Unlike the check in ip_finish_output(), it doesn't check for GSO.  I
> > triggered this with the GSO TUN patches, so not sure if it needs to be
> > in 2.6.25 or not (do we otherwise forward GSO packets?).
> > 
> > Cc: John Heffner <jheffner@....edu>
> > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> Since this is a regression for Xen, I would say yes.

Applied.

But Rusty, when referencing commits, always provide a
text string of the commit's header line because in
different trees and backports the commit ID may
change.

I fixed it up this time...

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html