[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080328.162551.252642805.davem@davemloft.net>
Date: Fri, 28 Mar 2008 16:25:51 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: mingo@...e.hu, Matheos.Worku@....COM, jesse.brandeburg@...el.com,
jarkao2@...il.com, netdev@...r.kernel.org, hadi@...erus.ca
Subject: Re: 2.6.24 BUG: soft lockup - CPU#X
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 28 Mar 2008 19:29:28 +0800
> [NET]: Add preemption point in qdisc_run
>
> The qdisc_run loop is currently unbounded and runs entirely
> in a softirq. This is bad as it may create an unbounded softirq
> run.
>
> This patch fixes this by calling need_resched and breaking out
> if necessary.
>
> It also adds a break out if the jiffies value changes since that
> would indicate we've been transmitting for too long which starves
> other softirqs.
>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
Applied, and I'll queue this up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists