netdev - [XFRM]: xfrm_user: fix selector family initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FCE30F.8060400@trash.net>
Date:	Wed, 09 Apr 2008 17:38:55 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Marco Berizzi <pupilla@...mail.com>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	Kazunori MIYAZAWA <kazunori@...azawa.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: [XFRM]: xfrm_user: fix selector family initialization

Patrick McHardy wrote:
> Patrick McHardy wrote:
>> The problem appears to be that openswan doesn't initialize the
>> selectors family when adding new SAs. xfrm_init_state() uses
>> the family to decide whether to set up inter family SAs or
>> regular SAs. We used to fix up the family in xfrm_user, but
>> this is now only done for transport mode SAs.
>>
>> -       /*
>> -        * Set inner address family if the KM left it as zero.
>> -        * See comment in validate_tmpl.
>> -        */
>> -       if (!x->sel.family)
>> +       if (x->props.mode == XFRM_MODE_TRANSPORT)
>>                 x->sel.family = p->family;
>> +
>>
>> Reverting this part should fix it, but would break inter family
>> tunnels again. It seems we need a different indication for
>> xfrm_init_state() for inter family SAs.
>>
>> Kazunori, any ideas?
> 
> 
> Did you have a chance to look into this? This is most likely
> going to break a lot of setups, so a fix is really needed
> before 2.6.25 is released.

<sigh>

Marco, could you test this patch please?



View attachment "x" of type "text/plain" (1155 bytes)