netdev - Re: 2.6.25-rc8 regression with openswan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47FBC2AF.7050508@trash.net>
Date:	Tue, 08 Apr 2008 21:08:31 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Marco Berizzi <pupilla@...mail.com>
CC:	netdev@...r.kernel.org, Kazunori MIYAZAWA <kazunori@...azawa.org>
Subject: Re: 2.6.25-rc8 regression with openswan

Patrick McHardy wrote:
> The problem appears to be that openswan doesn't initialize the
> selectors family when adding new SAs. xfrm_init_state() uses
> the family to decide whether to set up inter family SAs or
> regular SAs. We used to fix up the family in xfrm_user, but
> this is now only done for transport mode SAs.
>
> -       /*
> -        * Set inner address family if the KM left it as zero.
> -        * See comment in validate_tmpl.
> -        */
> -       if (!x->sel.family)
> +       if (x->props.mode == XFRM_MODE_TRANSPORT)
>                 x->sel.family = p->family;
> +
>
> Reverting this part should fix it, but would break inter family
> tunnels again. It seems we need a different indication for
> xfrm_init_state() for inter family SAs.
>
> Kazunori, any ideas?


Did you have a chance to look into this? This is most likely
going to break a lot of setups, so a fix is really needed
before 2.6.25 is released.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html