netdev - Re: [PATCH 2/7] ATM cell alignment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804111916590.3759@ask.diku.dk>
Date:	Fri, 11 Apr 2008 19:35:22 +0200 (CEST)
From:	Jesper Dangaard Brouer <hawk@...u.dk>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Stephen Hemminger <stephen.hemminger@...tta.com>,
	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 2/7] ATM cell alignment.

On Fri, 11 Apr 2008, Patrick McHardy wrote:

> Jesper Dangaard Brouer wrote:
>> @@ -87,6 +111,16 @@ int tc_calc_rtable(struct tc_ratespec *r, __u32
>>  *rtab, int cell_log, unsigned mt
>>           unsigned sz = ((i+1)<<cell_log);
>>           if (sz < mpu)
>>               sz = mpu;
>>  +        switch (linklayer) {
>>  +        case LINKLAYER_ATM:
>>  +            sz = tc_align_to_atm(sz);
>>  +            break;
>>  +        case LINKLAYER_ETHERNET:
>>  +            // No size adjustments on Ethernet
>>  +            break;
>
> Couldn't this use the ARPHRD values?

It would make it more difficult to expand to new linklayer types.  For 
example I cannot find a define suitable for DOCSIS (cabel modems) (Thats 
next om my list to make DaveM happy ;-))

If we need to use the ARPHRD values (ARPHRD_ATM + ARPHDR_ETHER), I'm 
wondering which "if_arp.h" is the correct to include.

#include <linux/if_arp.h>
  or
#include <net/if_arp.h>

Hilsen
   Jesper Brouer

--
-------------------------------------------------------------------
MSc. Master of Computer Science
Dept. of Computer Science, University of Copenhagen
Author of http://www.adsl-optimizer.dk
-------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html