netdev - Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4803903B.1020100@trash.net>
Date:	Mon, 14 Apr 2008 19:11:23 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	jeff@...zik.org, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 3/5] e1000e: Allow TSO to trickle down to VLAN device

Auke Kok wrote:
> Fix TSO over VLAN's by propagating settings to our VLAN devices.
>   

> @@ -378,8 +381,21 @@ static int e1000_set_tso(struct net_device *netdev, u32 data)
>  	} else {
>  		netdev->features &= ~NETIF_F_TSO;
>  		netdev->features &= ~NETIF_F_TSO6;
> +		/* disable TSO on all VLANs if they're present */
> +		if (!adapter->vlgrp)
> +			goto tso_out;
> +		for (i = 0; i < VLAN_GROUP_ARRAY_LEN; i++) {
> +			v_netdev = vlan_group_get_device(adapter->vlgrp, i);
> +			if (!v_netdev)
> +				continue;
> +
> +			v_netdev->features &= ~NETIF_F_TSO;
> +			v_netdev->features &= ~NETIF_F_TSO6;
> +			vlan_group_set_device(adapter->vlgrp, i, v_netdev);
>   

What exactly is this supposed to fix? If this simply wants
to propagate feature changes, I think it should use
netdev_feat_change and handle that within the VLAN code.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html