netdev - RE: [PATCH] net/bonding: Send more than one gratuitous ARP when slave takes over

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC32904E2B512@orsmsx414.amr.corp.intel.com>
Date:	Mon, 14 Apr 2008 10:50:17 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	<monis@...taire.com>, "Jay Vosburgh" <fubar@...ibm.com>
Cc:	"netdev" <netdev@...r.kernel.org>,
	"Olga Stern" <olgas@...taire.com>,
	"Or Gerlitz" <ogerlitz@...taire.com>
Subject: RE: [PATCH] net/bonding: Send more than one gratuitous ARP when slave takes over

Patch looks good to me, however I have a small nitpick below:

> +static ssize_t bonding_store_n_grat_arp(struct device *d,
> +				    struct device_attribute *attr,
> +				    const char *buf, size_t count)
> +{
> +	int new_value, ret = count;

Avoid declaring multiple variables on the same line when possible.
Write it like this:

	int new_value;
	int ret = count;

Here's a blurb from the Documentation/CodingStyle document (not gospel,
but pretty darn close):

It's also important to comment data, whether they are basic types or
derived
types.  To this end, use just one data declaration per line (no commas
for
multiple data declarations).  This leaves you room for a small comment
on each
item, explaining its use.

Cheers,
-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html