netdev - Re: [PATCH] net/bonding: Send more than one gratuitous ARP when slave takes over

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080414.144032.39791824.davem@davemloft.net>
Date:	Mon, 14 Apr 2008 14:40:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	monis@...taire.com, fubar@...ibm.com, netdev@...r.kernel.org,
	olgas@...taire.com, ogerlitz@...taire.com
Subject: Re: [PATCH] net/bonding: Send more than one gratuitous ARP when
 slave takes over

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Mon, 14 Apr 2008 10:50:17 -0700

> Patch looks good to me, however I have a small nitpick below:
> 
> > +static ssize_t bonding_store_n_grat_arp(struct device *d,
> > +				    struct device_attribute *attr,
> > +				    const char *buf, size_t count)
> > +{
> > +	int new_value, ret = count;
> 
> Avoid declaring multiple variables on the same line when possible.
> Write it like this:
> 
> 	int new_value;
> 	int ret = count;
> 
> Here's a blurb from the Documentation/CodingStyle document (not gospel,
> but pretty darn close):
> 
> It's also important to comment data, whether they are basic types or
> derived
> types.  To this end, use just one data declaration per line (no commas
> for
> multiple data declarations).  This leaves you room for a small comment
> on each
> item, explaining its use.

You're telling this person to use more lines, but not telling them to
add comments, yet that is the reasoning behind the very CodingStyle
recommendation you are quoting.

I think you're recommendation is gratuitous and in my opinion wrong.
Splitting up the line adds no value, and makes the function take up
more lines on the terminal screen.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html