netdev - Re: [PATCH][NET_SCHED] sch_api: fix qdisc_tree_decrease

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080414.151102.169978802.davem@davemloft.net>
Date:	Mon, 14 Apr 2008 15:11:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	jarkao2@...il.com, enrico@...erclick.com, netdev@...r.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop

From: Patrick McHardy <kaber@...sh.net>
Date: Mon, 14 Apr 2008 22:28:52 +0200

> Jarek Poplawski wrote:
> > [NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop
> >
> > TC_H_MAJ(parentid) for root classes is the same as for ingress, and if
> > ingress qdisc is created qdisc_lookup() returns its pointer (without
> > ingress NULL is returned). After this all qdisc_lookups give the same,
> > and we get endless loop. (I don't know how this could hide for so
> > long - it should trigger with every leaf class deleted if it's qdisc
> > isn't empty.)
> >
> > After this fix qdisc_lookup() is omitted both for ingress and root
> > parents, but looking for root is only wasting a little time here...
> > Many thanks to Enrico Demarin for finding a test for catching this
> > bug, which probably bothered quite a lot of admins.
> >   
> 
> Good catch, I agree that this is the reason for sure.

I'll take that as an ACK :-)

Applied, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html