netdev - Re: [PATCH][NET_SCHED] sch_api: fix qdisc_tree_decrease

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080415053253.GA3920@ff.dom.local>
Date:	Tue, 15 Apr 2008 05:32:54 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	kaber@...sh.net, enrico@...erclick.com, netdev@...r.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_api: fix qdisc_tree_decrease_qlen() loop

On Mon, Apr 14, 2008 at 03:11:02PM -0700, David Miller wrote:
...
> > Jarek Poplawski wrote:
...
> > > After this fix qdisc_lookup() is omitted both for ingress and root
> > > parents, but looking for root is only wasting a little time here...

...Actually, there is yet a possibility that somebody uses ffff:
handle for a qdisc (not ingress), which could make here a little
difference, so this place could be improved for this case (even
with something like my earlier debugging patch in this thread,
which BTW could be a safety for maybe some other quirks here),
but it seems it would be better to discourage using this handle
for anything but ingress.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html