lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 18 Apr 2008 15:43:58 -0700 (PDT)
From:	David Miller <>
Subject: Re: [PATCH] Fix and allocate less memory for ->priv'less netdevices

From: Alexey Dobriyan <>
Date: Fri, 18 Apr 2008 19:10:29 +0400

> This patch effectively reverts commit d0498d9ae1a5cebac363e38907266d5cd2eedf89
> aka "[NET]: Do not allocate unneeded memory for dev->priv alignment."
> It was found to be buggy because of final unconditional += NETDEV_ALIGN_CONST
> removal.
> For example, for sizeof(struct net_device) being 2048 bytes, "alloc_size"
> was also 2048 bytes, but allocator with debugging options turned on started
> giving out !32-byte aligned memory resulting in redzones overwrites.
> Patch does small optimization in ->priv'less case: bumping size to next
> 32-byte boundary was always done to ensure ->priv will also be aligned.
> But, no ->priv, no need to do that.
> Signed-off-by: Alexey Dobriyan <>

Thanks for finding and fixing this regression.

Patch applied.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists