netdev - Re: [PATCH] Fix and allocate less memory for ->priv'less netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080418.154358.247414309.davem@davemloft.net>
Date:	Fri, 18 Apr 2008 15:43:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	adobriyan@...allels.com
Cc:	netdev@...r.kernel.org, devel@...nvz.org, xemul@...nvz.org
Subject: Re: [PATCH] Fix and allocate less memory for ->priv'less netdevices

From: Alexey Dobriyan <adobriyan@...allels.com>
Date: Fri, 18 Apr 2008 19:10:29 +0400

> This patch effectively reverts commit d0498d9ae1a5cebac363e38907266d5cd2eedf89
> aka "[NET]: Do not allocate unneeded memory for dev->priv alignment."
> It was found to be buggy because of final unconditional += NETDEV_ALIGN_CONST
> removal.
> 
> For example, for sizeof(struct net_device) being 2048 bytes, "alloc_size"
> was also 2048 bytes, but allocator with debugging options turned on started
> giving out !32-byte aligned memory resulting in redzones overwrites.
> 
> Patch does small optimization in ->priv'less case: bumping size to next
> 32-byte boundary was always done to ensure ->priv will also be aligned.
> But, no ->priv, no need to do that.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...ru>

Thanks for finding and fixing this regression.

Patch applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html