netdev - Re: [patch 3/3] hci_usb.h: fix hard-to-trigger race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080418.154107.112850113.davem@davemloft.net>
Date:	Fri, 18 Apr 2008 15:41:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	marcel@...tmann.org, hidave.darkstar@...il.com,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	pavel@....cz, pavel@...e.cz
Subject: Re: [patch 3/3] hci_usb.h: fix hard-to-trigger race

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Fri, 18 Apr 2008 14:21:53 -0700

> On Fri, 18 Apr 2008 23:10:12 +0200
> Marcel Holtmann <marcel@...tmann.org> wrote:
> 
> > Hi Andrew,
> > 
> > > From: Pavel Machek <pavel@....cz>
> > >
> > > If someone tries to _urb_unlink while _urb_queue_head is running,  
> > > he'll see
> > > _urb->queue == NULL and fail to do any locking.  Prevent that from  
> > > happening
> > > by strategically placed barriers.
> > 
> > let me repeat this, the hci_usb driver is not worth fixing. Doing our  
> > own URB handling is a bad idea. The btusb driver should fix all of  
> > this. Only exception is that it is missing all the quirks, but that  
> > was me being lazy.
> > 
> 
> ok...  But as long as the old code is buildable and installable, we should
> fix bugs in it?

Yep.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html