lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 19 Apr 2008 00:34:30 +0200
From:	Pavel Machek <pavel@....cz>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	akpm@...ux-foundation.org, hidave.darkstar@...il.com,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation

On Fri 2008-04-18 23:07:10, Marcel Holtmann wrote:
> Hi Andrew,
>
>> From: Pavel Machek <pavel@....cz>
>>
>> _urb_free is an alias for kfree... making code longer & harder to
>> read. Remove it.
>
> our own URB handling here is broken anyway. It was a bad idea when we did 
> it, but at that time the USB susbsystem was not in that good shape that it 
> is today. So I would say leave this code as it is and concentrate on the 
> new btusb driver, but if it helps anybody I am happy to ACK this one.

It currently corrupts memory (use after free) during suspend, and I'm
trying to get that fixed. It is 90% reproducible.

And yes, fixing clean code is easier.

It could be easily fixed by just not freeing the urbs during
disconnect (introducing very very slow memory leak). Would that be
acceptable?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists