netdev - Re: [patch 2/3] hci_usb: remove code obfuscation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9BEB490E-DE8A-4018-9696-E5074CC638AC@holtmann.org>
Date:	Fri, 18 Apr 2008 23:07:10 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	akpm@...ux-foundation.org
Cc:	hidave.darkstar@...il.com, linux-bluetooth@...r.kernel.org,
	netdev@...r.kernel.org, pavel@....cz, pavel@...e.cz
Subject: Re: [patch 2/3] hci_usb: remove code obfuscation

Hi Andrew,

> From: Pavel Machek <pavel@....cz>
>
> _urb_free is an alias for kfree... making code longer & harder to
> read. Remove it.

our own URB handling here is broken anyway. It was a bad idea when we  
did it, but at that time the USB susbsystem was not in that good shape  
that it is today. So I would say leave this code as it is and  
concentrate on the new btusb driver, but if it helps anybody I am  
happy to ACK this one.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html