| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Apr 2008 03:28:34 +0200 From: Marcel Holtmann <marcel@...tmann.org> To: Pavel Machek <pavel@....cz> Cc: akpm@...ux-foundation.org, hidave.darkstar@...il.com, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [patch 2/3] hci_usb: remove code obfuscation Hi Pavel, >>> _urb_free is an alias for kfree... making code longer & harder to >>> read. Remove it. >> >> our own URB handling here is broken anyway. It was a bad idea when >> we did >> it, but at that time the USB susbsystem was not in that good shape >> that it >> is today. So I would say leave this code as it is and concentrate >> on the >> new btusb driver, but if it helps anybody I am happy to ACK this one. > > It currently corrupts memory (use after free) during suspend, and I'm > trying to get that fixed. It is 90% reproducible. that is good, because I can't reproduce it with any of my system. Don't ask me why. I really simply works. So if you figure it out, it would be great. > It could be easily fixed by just not freeing the urbs during > disconnect (introducing very very slow memory leak). Would that be > acceptable? I don't think so. Have you ever tried btusb driver? That code is a lot cleaner and it uses USB anchors for the queued URBs (no home grown broken URB queues). Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists