netdev - Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit kernels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080425.000418.108840147.davem@davemloft.net>
Date:	Fri, 25 Apr 2008 00:04:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	dlstevens@...ibm.com, netdev@...r.kernel.org
Subject: Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit
 kernels.

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
Date: Fri, 25 Apr 2008 15:59:22 +0900 (JST)

> In article <20080424.234748.53723057.davem@...emloft.net> (at Thu, 24 Apr 2008 23:47:48 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> 
> > From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
> > Date: Fri, 25 Apr 2008 15:37:33 +0900 (JST)
> > 
> > > In article <20080424.233159.06679047.davem@...emloft.net> (at Thu, 24 Apr 2008 23:31:59 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> > > 
> > > > 1) Use copy_in_user() as that's the proper interaface to copy within
> > > >    userspace in COMPAT code.
> > > 
> > > So, don't we care increase of copy operation with it?
> > 
> > I think for now it's an OK tradeoff, but yes it does increase
> > copies.  But then again, many compat layer handlers do.
> 
> And in IPv4, group_XXX{} handlers are even wrappers for ip_mreqXXX{}
> handlers so we we have another copy...

It is always possible to simplify things and make them more efficient.
And we should always do that.

The priority at the moment should be the simplist bug fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html