[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080425.162417.25756786.yoshfuji@linux-ipv6.org>
Date: Fri, 25 Apr 2008 16:24:17 +0900 (JST)
From: YOSHIFUJI Hideaki / 吉藤英明
<yoshfuji@...ux-ipv6.org>
To: davem@...emloft.net
Cc: dlstevens@...ibm.com, netdev@...r.kernel.org,
yoshfuji@...ux-ipv6.org
Subject: Re: [GIT PULL] [IPV6] COMPAT: Fix SSM applications on 64bit
kernels.
In article <20080425.000418.108840147.davem@...emloft.net> (at Fri, 25 Apr 2008 00:04:18 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
> Date: Fri, 25 Apr 2008 15:59:22 +0900 (JST)
>
> > In article <20080424.234748.53723057.davem@...emloft.net> (at Thu, 24 Apr 2008 23:47:48 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> >
> > > From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
> > > Date: Fri, 25 Apr 2008 15:37:33 +0900 (JST)
> > >
> > > > In article <20080424.233159.06679047.davem@...emloft.net> (at Thu, 24 Apr 2008 23:31:59 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> > > >
> > > > > 1) Use copy_in_user() as that's the proper interaface to copy within
> > > > > userspace in COMPAT code.
> > > >
> > > > So, don't we care increase of copy operation with it?
> > >
> > > I think for now it's an OK tradeoff, but yes it does increase
> > > copies. But then again, many compat layer handlers do.
> >
> > And in IPv4, group_XXX{} handlers are even wrappers for ip_mreqXXX{}
> > handlers so we we have another copy...
>
> It is always possible to simplify things and make them more efficient.
> And we should always do that.
>
> The priority at the moment should be the simplist bug fix.
Okay I will pend them for net-2.6.27.
--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists