netdev - Re: [PATCH net-2.6/stable] [XFRM] AUDIT: Fix flowlabel text format.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080426.222512.134613395.davem@davemloft.net>
Date:	Sat, 26 Apr 2008 22:25:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	jmorris@...ei.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6/stable] [XFRM] AUDIT: Fix flowlabel text format.

From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>
Date: Sun, 27 Apr 2008 12:54:37 +0900 (JST)

> In article <20080426.202558.208247674.davem@...emloft.net> (at Sat, 26 Apr 2008 20:25:58 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> 
> > What about the format is it fixing?
> 
> Sorry...

I now understand the problem with the new changelog message.

> > Also, can this possibly break existing audit log scanning
> > tools and parsers?
> 
> James?
> 
> We could add "flowlabel", but it is possible to break something, too.
> Anyway, because the log format did not make sense as audit log,
> we need to fix it.
> 
> ---
> [XFRM] AUDIT: Fix flowlabel text format ambibuity.
> 
> Flowlabel text format was not correct and thus ambiguous.
> For example, 0x00123 or 0x01203 are formatted as 0x123.
> This is not what audit tools want.
> 
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>

Patch applied, James if you have some objections let me know,
otherwise I'll toss this to -stable too.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html