netdev - Re: [PATCH net-2.6/stable] [XFRM] AUDIT: Fix flowlabel text format.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Xine.LNX.4.64.0804280908470.1406@us.intercode.com.au>
Date:	Mon, 28 Apr 2008 09:09:12 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	David Miller <davem@...emloft.net>
cc:	YOSHIFUJI Hideaki / �������� 
	<yoshfuji@...ux-ipv6.org>, netdev@...r.kernel.org,
	Paul Moore <paul.moore@...com>
Subject: Re: [PATCH net-2.6/stable] [XFRM] AUDIT: Fix flowlabel text format.

On Sat, 26 Apr 2008, David Miller wrote:

> From: YOSHIFUJI Hideaki / �������� <yoshfuji@...ux-ipv6.org>
> Date: Sun, 27 Apr 2008 12:54:37 +0900 (JST)
> 
> > In article <20080426.202558.208247674.davem@...emloft.net> (at Sat, 26 Apr 2008 20:25:58 -0700 (PDT)), David Miller <davem@...emloft.net> says:
> > 
> > > What about the format is it fixing?
> > 
> > Sorry...
> 
> I now understand the problem with the new changelog message.
> 
> > > Also, can this possibly break existing audit log scanning
> > > tools and parsers?
> > 
> > James?
> > 
> > We could add "flowlabel", but it is possible to break something, too.
> > Anyway, because the log format did not make sense as audit log,
> > we need to fix it.
> > 
> > ---
> > [XFRM] AUDIT: Fix flowlabel text format ambibuity.
> > 
> > Flowlabel text format was not correct and thus ambiguous.
> > For example, 0x00123 or 0x01203 are formatted as 0x123.
> > This is not what audit tools want.
> > 
> > Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> 
> Patch applied, James if you have some objections let me know,
> otherwise I'll toss this to -stable too.

Ok, cc'ing Paul Moore, who's maintining this now.


-- 
James Morris
<jmorris@...ei.org>