[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4814406B.8000907@gmail.com>
Date: Sun, 27 Apr 2008 10:59:23 +0200
From: Jiri Slaby <jirislaby@...il.com>
To: Ondrej Zajicek <santiago@...reenet.org>
CC: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, rl@...lgate.ch
Subject: Re: [PATCH] via-rhine: suspend/resume bugfix
On 04/27/2008 09:13 AM, Ondrej Zajicek wrote:
> There is a bug in via-rhine driver - the driver don't disable
> interrupts during suspend, which sometimes leads to globally
> disabled interrupt line.
>
> This patch disables interrupts (and Rx/Tx) during suspend.
>
> Signed-off-by: Ondrej Zajicek <santiago@...reenet.org>
>
> ---
>
> diff -uprN -X linux-2.6.25/Documentation/dontdiff linux-2.6.25/drivers/net/via-rhine.c linux-2.6.25-feanor/drivers/net/via-rhine.c
> --- linux-2.6.25/drivers/net/via-rhine.c 2008-04-17 04:49:44.000000000 +0200
> +++ linux-2.6.25-feanor/drivers/net/via-rhine.c 2008-04-26 14:08:44.000000000 +0200
> @@ -1886,6 +1886,15 @@ static void rhine_shutdown (struct pci_d
> struct rhine_private *rp = netdev_priv(dev);
> void __iomem *ioaddr = rp->base;
>
> + /* Switch to loopback mode to avoid hardware races. */
> + iowrite8(rp->tx_thresh | 0x02, ioaddr + TxConfig);
> +
> + /* Disable interrupts by clearing the interrupt mask. */
> + iowrite16(0x0000, ioaddr + IntrEnable);
> +
> + /* Stop the chip's Tx and Rx processes. */
> + iowrite16(CmdStop, ioaddr + ChipCmd);
> +
> if (!(rp->quirks & rqWOL))
> return; /* Nothing to do for non-WOL adapters */
What about PCI posting?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists