netdev - Re: [PATCH] add compat support for getsockopt (MCAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080428.165220.27263306.yoshfuji@linux-ipv6.org>
Date:	Mon, 28 Apr 2008 16:52:20 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	dlstevens@...ibm.com, davem@...emloft.net
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] add compat support for getsockopt (MCAST_MSFILTER)

In article <OF81CA6D67.1BAD70DD-ON88257439.00251005-88257439.0025FC25@...ibm.com> (at Sun, 27 Apr 2008 23:54:56 -0700), David Stevens <dlstevens@...ibm.com> says:

> YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> wrote on 04/27/2008 
> 11:36:50 PM:
> 
> > IMHO, It's much better to split into 2 pathces - bug fixes and
> > getsockopt() support...
> 
>         Ordinarily, I'd agree, but I came across this in the
> getsockopt code which has the same issue and both the
> new code and fix require the same #define that's in the
> getsockopt code. I retested all of it before submitting, too.

That does not seem to be an excuse, and it is not a
good practice to me.

- Several cleanups for the setsockopt compat support.
- Add compat support for getsockopt (MCAST_MSFILTER)

Feel free to use these, sync'ed with current net-2.6.

-- 
YOSHIFUJI Hideaki @ USAGI Project  <yoshfuji@...ux-ipv6.org>
GPG-FP  : 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

View attachment "0001-Several-cleanups-for-the-setsockopt-compat-support.txt" of type "Text/Plain" (2667 bytes)

View attachment "0002-Add-compat-support-for-getsockopt-MCAST_MSFILTER.txt" of type "Text/Plain" (5480 bytes)