| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080429.032336.113977430.davem@davemloft.net> Date: Tue, 29 Apr 2008 03:23:36 -0700 (PDT) From: David Miller <davem@...emloft.net> To: yoshfuji@...ux-ipv6.org Cc: dlstevens@...ibm.com, netdev@...r.kernel.org Subject: Re: [PATCH] add compat support for getsockopt (MCAST_MSFILTER) From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> Date: Mon, 28 Apr 2008 16:52:20 +0900 (JST) > In article <OF81CA6D67.1BAD70DD-ON88257439.00251005-88257439.0025FC25@...ibm.com> (at Sun, 27 Apr 2008 23:54:56 -0700), David Stevens <dlstevens@...ibm.com> says: > > > YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org> wrote on 04/27/2008 > > 11:36:50 PM: > > > > > IMHO, It's much better to split into 2 pathces - bug fixes and > > > getsockopt() support... > > > > Ordinarily, I'd agree, but I came across this in the > > getsockopt code which has the same issue and both the > > new code and fix require the same #define that's in the > > getsockopt code. I retested all of it before submitting, too. > > That does not seem to be an excuse, and it is not a > good practice to me. > > - Several cleanups for the setsockopt compat support. > - Add compat support for getsockopt (MCAST_MSFILTER) > > Feel free to use these, sync'ed with current net-2.6. Fair enough, I've applied these two patches. Thanks everyone! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists