netdev - Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zlrdtw6q.fsf@natisbad.org>
Date:	Tue, 29 Apr 2008 01:07:57 +0200
From:	arno@...isbad.org (Arnaud Ebalard)
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.

Hi,

Patrick McHardy <kaber@...sh.net> writes:

> Good catch, thanks. That code seems to be very resistent against
> attempts to fix it :)
>
> Patch applied, and I'll also send it to -stable once it hits
> upstream.

Ack.

BTW, while looking at the code, I noticed the call to skb_copy_expand()
leads to a complete copy of current sk_buff data to the new sk_buff.
Those data are then completely rewritten a few lines later. Too bad
there is no simple way (considering skbuff.h) to prevent the useless
copy.

Cheers,

a+

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html