netdev - Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48203079.60001@trash.net>
Date:	Tue, 06 May 2008 12:18:33 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Arnaud Ebalard <arno@...isbad.org>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Netfilter Developer Mailing List 
	<netfilter-devel@...r.kernel.org>
Subject: Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough
 space for bigger reinjected packet.

Arnaud Ebalard wrote:
> BTW, while looking at the code, I noticed the call to skb_copy_expand()
> leads to a complete copy of current sk_buff data to the new sk_buff.
> Those data are then completely rewritten a few lines later. Too bad
> there is no simple way (considering skbuff.h) to prevent the useless
> copy.


Yeah, thats a bit unfortunate. I don't see how we could avoid
this besides allocating a fresh skb and setting up all the meta
data manually though.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html