netdev - Re: [PATCH] ipvs: fix oops in backup for fwmark conn templates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0804281151550.3315@u.domain.uli>
Date:	Mon, 28 Apr 2008 11:58:55 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Simon Horman <horms@...ge.net.au>
cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Andy Gospodarek <andy@...yhouse.net>,
	"Rumen G. Bogdanovski" <rumen@...cecho.com>,
	Wensong Zhang <wensong@...ux-vs.org>
Subject: Re: [PATCH] ipvs: fix oops in backup for fwmark conn templates


	Hello,

On Mon, 28 Apr 2008, Simon Horman wrote:

> On Mon, Apr 28, 2008 at 10:52:38AM +0300, Julian Anastasov wrote:
> > 
> > 	Fixes bug http://bugzilla.kernel.org/show_bug.cgi?id=10556
> > where conn templates with protocol=IPPROTO_IP can oops backup box.
> > 
> >         Result from ip_vs_proto_get() should be checked because
> > protocol value can be invalid or unsupported in backup. But
> > for valid message we should not fail for templates which use
> > IPPROTO_IP. Also, add checks to validate message limits and
> > connection state. Show state NONE for templates using IPPROTO_IP.
> 
> Julian, am I right in thinking that this is a long-standing bug
> rather than a recent regression?

	Bug reporter is using 2.6.24.4, bug comes with 2.6.24,
pp is NULL for IPPROTO_IP, 2.6.24 shows:

[IPVS]: use proper timeout instead of fixed value

-               cp->timeout = IP_VS_SYNC_CONN_TIMEOUT;
+               cp->state = ntohs(s->state);
+               pp = ip_vs_proto_get(s->protocol);
+               cp->timeout = pp->timeout_table[cp->state];

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html