netdev - Re: useless tcp maybe-bug report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080428.020123.07945936.davem@davemloft.net>
Date:	Mon, 28 Apr 2008 02:01:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org
Subject: Re: useless tcp maybe-bug report

From: Andrew Morton <akpm@...ux-foundation.org>
Date: Mon, 28 Apr 2008 01:40:49 -0700

> I just fired up latest mainline plus the 300-odd patches which I'm about to
> send Linuswards on a mac g5.
> 
> I use that g5 as a distcc server.  I'm now seeing this:
> 
> distcc[13554] (dcc_writex) ERROR: failed to write: Connection reset by peer
> distcc[13554] (dcc_writex) ERROR: failed to write: Broken pipe
> distcc[13554] Warning: failed to distribute net/atm/clip.mod.c to g5/32, running locally instead
> 
> about once per allmodconfig build.  The client kernel is 2.6.24.3-34.fc8
> and has never changed.
> 
> Thing is, these messages are unusual.  I suspect that Something Is Up with
> that g5, perhaps its networking.
> 
> There are no signs of problems in the g5's dmesg.

I bet your fc8 kernel has the bug that needs this patch below.

The bug causes timewait sockets to reset erroneously and matches your
symptoms precisely.

commit 7951f0b03a63d657c72c7d54d306ef3357e7e604
Author: Daniel Lezcano <dlezcano@...ibm.com>
Date:   Thu Apr 10 20:53:10 2008 -0700

    [NETNS][IPV6] tcp - assign the netns for timewait sockets
    
    Copy the network namespace from the socket to the timewait socket.
    
    Signed-off-by: Daniel Lezcano <dlezcano@...ibm.com>
    Acked-by: Mark Lord <mlord@...ox.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c
index 876169f..717c411 100644
--- a/net/ipv4/inet_timewait_sock.c
+++ b/net/ipv4/inet_timewait_sock.c
@@ -124,6 +124,7 @@ struct inet_timewait_sock *inet_twsk_alloc(const struct sock *sk, const int stat
 		tw->tw_hash	    = sk->sk_hash;
 		tw->tw_ipv6only	    = 0;
 		tw->tw_prot	    = sk->sk_prot_creator;
+		tw->tw_net          = sk->sk_net;
 		atomic_set(&tw->tw_refcnt, 1);
 		inet_twsk_dead_node_init(tw);
 		__module_get(tw->tw_prot->owner);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html