netdev - RE: [RFC/RFT 4/4] mac80211: use multi-queue master netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1209586047.18659.93.camel@johannes.berg>
Date:	Wed, 30 Apr 2008 22:07:27 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	"Rindjunsky, Ron" <ron.rindjunsky@...el.com>,
	Tomas Winkler <tomasw@...il.com>,
	Ivo van Doorn <ivdoorn@...il.com>
Subject: RE: [RFC/RFT 4/4] mac80211: use multi-queue master netdevice


> > +void ieee80211_start_queue(struct ieee80211_hw *hw, int queue)
> > +{
> > +	struct ieee80211_local *local = hw_to_local(hw);
> > +#ifdef CONFIG_MAC80211_QOS
> > +	netif_start_subqueue(local->mdev, queue);
> > +#else
> > +	WARN_ON(queue != 0);
> > +	netif_start_queue(local->mdev);
> > +#endif
> > +}
> > +EXPORT_SYMBOL(ieee80211_start_queue);
> > +
> 
> I would suggest that you enable the netdev feature flag for
> NETIF_F_MULTI_QUEUE on devices when you create them.  That way you can
> have things like ieee80211_start_queue() key on that instead of a
> compile-time option, in case wireless devices come along that won't
> support multiple queues, if that's possible. 

Ah. I thought that then I'd just create a device with alloc_mq with a
single queue.

> If you think this is a decent idea, I'd suggest that any function that
> has a compile-time check for multiqueue being changed to use the runtime
> check.  Then in your device setup, where you call netdev_alloc_mq(),
> there you set the flag NETIF_F_MULTI_QUEUE based on the device features.

Hah, indeed, I don't currently set it at all. Yes, I guess I should do
it that way.

> Other than that, this patch looks great.  Exciting to see this starting
> to take flight.

:)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)