lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 01 May 2008 02:51:37 -0700 (PDT)
From:	David Miller <>
Subject: Re: [PATCH 1/2] Disable forwarding of LRO skbs

From: Ben Hutchings <>
Date: Wed, 30 Apr 2008 22:51:26 +0100

> Add skb_warn_if_lro() to test whether an skb was received with LRO and
> warn if so.
> Change br_forward(), ip_forward() and ip6_forward() to call
> skb_warn_if_lro() and discard the skb if it returns true.

This skb_is_gso() test should be inline.

So, instead make this something like:


extern bool __skb_warn_if_lro(const struct sk_buff *skb);

static inline bool skb_warn_if_lro(const struct sk_buff *skb)
	if (unlikely(skb_is_gso(skb)))
		return __skb_warn_if_lro(skb);
	return false;


bool skb_warn_if_lro(const struct sk_buff *skb)
	if (net_ratelimit())
		pr_warning("%s: received packets cannot be forwarded"
			   " while LRO is enabled\n", skb->dev->name);
	return true;

Can you make this correction and resubmit this patch?

The second one looks fine to me, you don't need to resubmit
that one.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists