lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 01 May 2008 18:19:54 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: davem@...emloft.net (David Miller) Cc: bhutchings@...arflare.com, kmansley@...arflare.com, shemminger@...tta.com, netdev@...r.kernel.org Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs David Miller <davem@...emloft.net> wrote: > From: Ben Hutchings <bhutchings@...arflare.com> > Date: Wed, 30 Apr 2008 22:48:46 +0100 > >> Large Receive Offload (LRO) destroys packet headers that should be >> preserved when forwarding. Currently it also triggers a BUG() or WARN() >> in skb_gso_segment(). We should disable it wherever forwarding is >> enabled, and discard LRO skbs with a warning if it is turned back on. > > Thanks for reposting your work, I'll take a closer look at these > two patches later today. This patch completely breaks forwarding of GSO packets in a virtualised environment where we explicitly want to forward them as is to reduce per-packet overhead. So if LRO is causing problems then I suggest we find a better way around that that does not penalise all forms of GSO. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists