netdev - Re: [ofa-general] RE: [PATCH 11/13] QLogic VNIC: Driver utility file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <71d336490805011001he7359dfw831470986d87b385@mail.gmail.com>
Date:	Thu, 1 May 2008 22:31:10 +0530
From:	"Ramachandra K" <ramachandra.kuchimanchi@...gic.com>
To:	"Stephen Hemminger" <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, rdreier@...co.com,
	"Poornima Kamath (Contractor - )" <poornima.kamath@...gic.com>,
	general@...ts.openfabrics.org,
	"Amar Mudrankit (Contractor - )" <amar.mudrankit@...gic.com>
Subject: Re: [ofa-general] RE: [PATCH 11/13] QLogic VNIC: Driver utility file - implements various utility macros

Sorry for the resend. Original mail bounced from netdev.

On Thu, May 1, 2008 at 9:48 PM <ramachandra.kuchimanchi@...gic.com> wrote:
> Stephen,
>
>
>  Stephen Hemminger [mailto:shemminger@...tta.com] wrote:
>
>  > Ramachandra K <ramachandra.kuchimanchi@...gic.com> wrote:
>
>  >> +#define is_power_of2(value) (((value) & ((value - 1))) == 0)
>  >> +#define ALIGN_DOWN(x, a)    ((x)&(~((a)-1)))
>
>  > In kernel.h already
>
>  Will fix this. Thanks.
>
>
>  >> +extern u32 vnic_debug;
>
>  > Use msg level macros instead?
>
>  I am sorry, I did not understand this comment.
>
>
>  > +
>  > +#define SYS_INFO(fmt, arg...)                                        \
>  > +      PRINT_CONDITIONAL(KERN_INFO,                           \
>  > +                        "SYS",                               \
>  > +                        (vnic_debug & DEBUG_SYS_INFO),       \
>  > +                        fmt, ##arg)
>  > +
>  > +#endif       /* VNIC_UTIL_H_INCLUDED */
>
>
>  > Many of these are already in standard macros pr_info, pr_err etc.
>
>  These macros are for providing a debug log level functionality through
>  the vnic_debug module parameter.
>
>  Regards,
>  Ram
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html