lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 1 May 2008 11:26:33 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	"Ramachandra K" <ramachandra.kuchimanchi@...gic.com>
Cc:	netdev@...r.kernel.org, rdreier@...co.com,
	"Poornima Kamath (Contractor - )" <poornima.kamath@...gic.com>,
	general@...ts.openfabrics.org,
	"Amar Mudrankit (Contractor - )" <amar.mudrankit@...gic.com>
Subject: Re: [ofa-general] RE: [PATCH 11/13] QLogic VNIC: Driver utility
 file - implements various utility macros

On Thu, 1 May 2008 22:31:10 +0530
"Ramachandra K" <ramachandra.kuchimanchi@...gic.com> wrote:

> Sorry for the resend. Original mail bounced from netdev.
> 
> On Thu, May 1, 2008 at 9:48 PM <ramachandra.kuchimanchi@...gic.com> wrote:
> > Stephen,
> >
> >
> >  Stephen Hemminger [mailto:shemminger@...tta.com] wrote:
> >
> >  > Ramachandra K <ramachandra.kuchimanchi@...gic.com> wrote:
> >
> >  >> +#define is_power_of2(value) (((value) & ((value - 1))) == 0)
> >  >> +#define ALIGN_DOWN(x, a)    ((x)&(~((a)-1)))
> >
> >  > In kernel.h already
> >
> >  Will fix this. Thanks.
> >
> >
> >  >> +extern u32 vnic_debug;
> >
> >  > Use msg level macros instead?

There is a ethtool mechanism to set message level for debug method, read other
network drivers and look at netif_msg_timer(x), netif_msg_probe(x), etc in
include/linux/netdevice.h

The goal here is to not have any special configuration for each different type
of hardware.  It is bad user design to have each hardware vendor choosing different
mechanism and values to enable debugging. You can argue that the existing infrastructure
is inadequate, in which case extend the infrastructure for all devices.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists