lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 01 May 2008 11:34:31 -0700
From: (Eric W. Biederman)
To:	"Serge E. Hallyn" <>
Cc:	Greg KH <>, Benjamin Thery <>,, Al Viro <>,
	Tejun Heo <>,
	Daniel Lezcano <>,
	Pavel Emelyanov <>,
Subject: Re: [PATCH 00/10] sysfs tagged directories

"Serge E. Hallyn" <> writes:

> Quoting Greg KH (
> Now before moving veth1 to the new netns, we have in the container:
> /sys/class/net:
> lo  sit0
> /sys/devices/virtual/net:
> lo  sit0
> and after moving veth1, we have in the container:
> /sys/class/net:
> lo  sit0  veth1
> /sys/devices/virtual/net:
> lo  sit0
> In the parent network namespace, veth1 is removed from /sys/class/net
> but remains in /sys/devices/virtual/net.

The symlink is gone by the real directory remains?

> I'm not sure whether this is the renaming bug that Daniel Lezcano's
> patch addresses.  If not (as I suspect) then that clearly needs to be
> fixed.
> Benjamin can you play around with this and test it with Daniel's
> patch?

Darn.  It appears we have a regression in this patchset.
That part used to work.

I was thinking of blaming sysfs_rename_link.  But it the
links are fine so it looks more likely that sysfs has morphed once
again and we have  a reference counting issue or something similar.
Yuck. d_move and the other moves should have worked.

>From a purely get the good less controversial parts of this
patchset in.  I suggest we look at patches 7/10 and 8/10 (without
the tag_ops).  And introduce and start using sysfs_delete_link
and sysfs_rename_link.  That code seems pretty stable and is
generally a code reduction all by itself by reducing a common
idiom into a single function.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists