lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 01 May 2008 16:53:49 -0700
From:	"Kok, Auke" <sofar@...-projects.org>
To:	Becky Bruce <bgill@...escale.com>, jgarzik@...ox.com
CC:	auke-jan.h.kok@...el.com, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH] e1000e: use resource_size_t, not unsigned long, for phys
 addrs

Becky Bruce wrote:
> The use of unsigned long causes the driver to fail on 32-bit systems
> which support 64-bit resources.
> 
> Signed-off-by: Becky Bruce <becky.bruce@...escale.com>

Acked-by: Auke Kok <auke-jan.h.kok@...el.com>

thanks Becky,

Auke

> ---
> 
> Resend, with proper CC.
> 
>  drivers/net/e1000e/netdev.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 8991ab8..dae3269 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3897,8 +3897,8 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
>  	struct e1000_adapter *adapter;
>  	struct e1000_hw *hw;
>  	const struct e1000_info *ei = e1000_info_tbl[ent->driver_data];
> -	unsigned long mmio_start, mmio_len;
> -	unsigned long flash_start, flash_len;
> +	resource_size_t mmio_start, mmio_len;
> +	resource_size_t flash_start, flash_len;
>  
>  	static int cards_found;
>  	int i, err, pci_using_dac;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists