netdev - Re: [PATCH] unify the macro get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080502035218.GC10542@colo.lackof.org>
Date:	Thu, 1 May 2008 21:52:18 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Grant Grundler <grundler@...isc-linux.org>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	gao changli <xiaosuo@...il.com>
Subject: Re: [PATCH] unify the macro get_u16 in the file tulip.h

On Wed, Apr 30, 2008 at 05:43:49PM -0700, Joe Perches wrote:
> On Wed, 2008-04-30 at 18:15 -0600, Grant Grundler wrote:
> > On Thu, May 01, 2008 at 01:34:38AM +0800, gao changli wrote:
> > > Unify the macro get_u16 with le16_to_cpu.
> > > Signed-off-by: Changli Gao <xiaosuo@...il.com>
> > Acked-by: Grant Grundler <grundler@...isc-linux.org>
> > please apply.  Depends on other patches that define le16_to_cpu().
> 
> Wouldn't it be better to remove get_u16 altogether
> and use le16_to_cpu or __le16_to_cpup directly?

Yes, it would be. But Changli's patch was an improvement in reducing
nested macros across several drivers and he was trying to minimize
churn with that patchset.

Can you please submit a patch that removes get_u16()?

thanks,
grant
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html