netdev - [PATCH] [2.6.26] [CAN] Fix can_send() handling on dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4820B665.6070609@hartkopp.net>
Date:	Tue, 06 May 2008 21:49:57 +0200
From:	Oliver Hartkopp <oliver@...tkopp.net>
To:	David Miller <davem@...emloft.net>
CC:	Urs Thuermann <urs@...ogud.escape.de>, nautsch@...il.com,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: [PATCH] [2.6.26] [CAN] Fix can_send() handling on dev_queue_xmit()
 failures

from Oliver Hartkopp <oliver@...tkopp.net>

The tx packet counting and the local loopback of CAN frames should
only happen in the case that the CAN frame has been enqueued to the
netdevice tx queue successfully.

Thanks to Andre Naujoks <nautsch@...il.com> for reporting this issue.

Signed-off-by: Oliver Hartkopp <oliver@...tkopp.net>
Signed-off-by: Urs Thuermann <urs@...ogud.escape.de>

---

Hello Dave,

this patch should go into 2.6.26 and also applies fine on 2.6.25.1.

IMO this issue is not that 'critical' that it *requires* to become
part of 2.6.25.2. Please forward the patch to Greg at your own opinion.

Many Thanks!
Oliver

View attachment "can_send.diff" of type "text/x-diff" (1313 bytes)